Discussion:
[PATCH] ARM: dts: Update video-phy node with syscon phandle for Exynos3250
Beata Michalska
2015-03-19 10:56:27 UTC
Permalink
As a follow-up to recent changes to Exynos mipi video phy
driver, introducing support for PMU regmap in commit
e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression
by adding support for PMU regmap") add a syscon phandle to
video-phy node to bring back to life both MIPI DSI displays
and MIPI CSIS-2 camera sensors on Exynos3250.

Signed-off-by: Beata Michalska <***@samsung.com>
---
arch/arm/boot/dts/exynos3250.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
index ac6b0ae..6c89670 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -137,6 +137,7 @@
compatible = "samsung,s5pv210-mipi-video-phy";
reg = <0x10020710 8>;
#phy-cells = <1>;
+ syscon = <&pmu_system_controller>;
};

pd_cam: cam-power-***@10023C00 {
--
1.7.9.5
Krzysztof Kozlowski
2015-05-21 01:57:29 UTC
Permalink
Post by Beata Michalska
As a follow-up to recent changes to Exynos mipi video phy
driver, introducing support for PMU regmap in commit
e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression
by adding support for PMU regmap") add a syscon phandle to
video-phy node to bring back to life both MIPI DSI displays
and MIPI CSIS-2 camera sensors on Exynos3250.
Reviewed-by: Krzysztof Kozlowski <***@samsung.com>
Tested-by: Krzysztof Kozlowski <***@samsung.com>

Tested on Gear 2 (Exynos3250) board.

I'll queue it and send later to Kukjin.

Best regards,
Krzysztof
Krzysztof Kozlowski
2015-05-21 02:04:28 UTC
Permalink
Post by Krzysztof Kozlowski
Post by Beata Michalska
As a follow-up to recent changes to Exynos mipi video phy
driver, introducing support for PMU regmap in commit
e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression
by adding support for PMU regmap") add a syscon phandle to
video-phy node to bring back to life both MIPI DSI displays
and MIPI CSIS-2 camera sensors on Exynos3250.
Tested on Gear 2 (Exynos3250) board.
Oh, I was too fast. It seems that "reg" property is not needed
anymore. Can you remove it?

Best regards,
Krzysztof
Javier Martinez Canillas
2015-05-21 07:25:45 UTC
Permalink
On Thu, May 21, 2015 at 4:04 AM, Krzysztof Kozlowski
Post by Krzysztof Kozlowski
Post by Krzysztof Kozlowski
Post by Beata Michalska
As a follow-up to recent changes to Exynos mipi video phy
driver, introducing support for PMU regmap in commit
e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression
by adding support for PMU regmap") add a syscon phandle to
video-phy node to bring back to life both MIPI DSI displays
and MIPI CSIS-2 camera sensors on Exynos3250.
Tested on Gear 2 (Exynos3250) board.
Oh, I was too fast. It seems that "reg" property is not needed
anymore. Can you remove it?
After removing the reg property as Krzysztof suggested.

Reviewed-by: Javier Martinez Canillas <***@collabora.co.uk>

Best regards,
Javier
Kukjin Kim
2015-05-23 03:53:16 UTC
Permalink
Post by Javier Martinez Canillas
On Thu, May 21, 2015 at 4:04 AM, Krzysztof Kozlowski
Post by Krzysztof Kozlowski
Post by Krzysztof Kozlowski
Post by Beata Michalska
As a follow-up to recent changes to Exynos mipi video phy
driver, introducing support for PMU regmap in commit
e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression
by adding support for PMU regmap") add a syscon phandle to
video-phy node to bring back to life both MIPI DSI displays
and MIPI CSIS-2 camera sensors on Exynos3250.
Tested on Gear 2 (Exynos3250) board.
Oh, I was too fast. It seems that "reg" property is not needed
anymore. Can you remove it?
After removing the reg property as Krzysztof suggested.
will apply with changing as per you guys' review comment ;-)

Thanks,
Kukjin
Beata Michalska
2015-05-26 08:50:30 UTC
Permalink
Hi,
Post by Kukjin Kim
Post by Javier Martinez Canillas
On Thu, May 21, 2015 at 4:04 AM, Krzysztof Kozlowski
Post by Krzysztof Kozlowski
Post by Krzysztof Kozlowski
Post by Beata Michalska
As a follow-up to recent changes to Exynos mipi video phy
driver, introducing support for PMU regmap in commit
e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression
by adding support for PMU regmap") add a syscon phandle to
video-phy node to bring back to life both MIPI DSI displays
and MIPI CSIS-2 camera sensors on Exynos3250.
Tested on Gear 2 (Exynos3250) board.
Oh, I was too fast. It seems that "reg" property is not needed
anymore. Can you remove it?
After removing the reg property as Krzysztof suggested.
will apply with changing as per you guys' review comment ;-)
Thanks,
Kukjin
Apologies for not jumping in earlier, but I've been away for a while,
with basically no e-mail access. Would You like me to resend the patch
with the 'reg' property removed or will You handle it while applying
the change ?

Best Regards
Beata

Loading...