Discussion:
[PATCH 08/11] ASoC: sun4i-spdif: Handle return value of clk_prepare_enable.
Arvind Yadav
2017-07-25 10:15:18 UTC
Permalink
clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <***@gmail.com>
---
sound/soc/sunxi/sun4i-spdif.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c
index eaefd07..4a316c0 100644
--- a/sound/soc/sunxi/sun4i-spdif.c
+++ b/sound/soc/sunxi/sun4i-spdif.c
@@ -458,11 +458,16 @@ static int sun4i_spdif_runtime_suspend(struct device *dev)
static int sun4i_spdif_runtime_resume(struct device *dev)
{
struct sun4i_spdif_dev *host = dev_get_drvdata(dev);
+ int ret;

- clk_prepare_enable(host->spdif_clk);
- clk_prepare_enable(host->apb_clk);
+ ret = clk_prepare_enable(host->spdif_clk);
+ if (ret)
+ return ret;
+ ret = clk_prepare_enable(host->apb_clk);
+ if (ret)
+ clk_disable_unprepare(host->spdif_clk);

- return 0;
+ return ret;
}

static int sun4i_spdif_probe(struct platform_device *pdev)
--
1.9.1
Loading...