Discussion:
[PATCH] clk: sunxi-ng: sun5i: Add clk_set_rate_parent to the CPU clock
Maxime Ripard
2017-07-21 16:19:35 UTC
Permalink
The current CPU clock is missing the option to change the rate of its
parents, leading to improper rates calculated by cpufreq, and eventually
crashes.

Cc: <***@vger.kernel.org>
Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
Reported-by: Kevin Hilman <***@baylibre.com>
Signed-off-by: Maxime Ripard <***@free-electrons.com>
---
drivers/clk/sunxi-ng/ccu-sun5i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/sunxi-ng/ccu-sun5i.c b/drivers/clk/sunxi-ng/ccu-sun5i.c
index 5372bf8be5e6..31d7ffda9aab 100644
--- a/drivers/clk/sunxi-ng/ccu-sun5i.c
+++ b/drivers/clk/sunxi-ng/ccu-sun5i.c
@@ -184,7 +184,7 @@ static struct ccu_mux cpu_clk = {
.hw.init = CLK_HW_INIT_PARENTS("cpu",
cpu_parents,
&ccu_mux_ops,
- CLK_IS_CRITICAL),
+ CLK_SET_RATE_PARENT | CLK_IS_CRITICAL),
}
};
--
2.13.3
Chen-Yu Tsai
2017-07-22 02:23:19 UTC
Permalink
On Sat, Jul 22, 2017 at 12:19 AM, Maxime Ripard
Post by Maxime Ripard
The current CPU clock is missing the option to change the rate of its
parents, leading to improper rates calculated by cpufreq, and eventually
crashes.
Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
Acked-by: Chen-Yu Tsai <***@csie.org>
Maxime Ripard
2017-07-24 09:37:26 UTC
Permalink
Post by Chen-Yu Tsai
On Sat, Jul 22, 2017 at 12:19 AM, Maxime Ripard
Post by Maxime Ripard
The current CPU clock is missing the option to change the rate of its
parents, leading to improper rates calculated by cpufreq, and eventually
crashes.
Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
Applied as a fix, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Loading...