Discussion:
[PATCH] ARM: socfpga: fix uart DMA binding error
Steffen Trumtrar
2015-02-19 12:07:52 UTC
Permalink
socfpga.dtsi is missing the DMA channels for the uart nodes.
This will produce the following errors:

of_dma_request_slave_channel: dma-names property of node '/soc/***@ffc02000' missing or empty
ttyS0 - failed to request DMA

Provide the correct DMA channels to fix this.

Signed-off-by: Steffen Trumtrar <***@pengutronix.de>
---
arch/arm/boot/dts/socfpga.dtsi | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
index 252c3d1bda50..9d8760956752 100644
--- a/arch/arm/boot/dts/socfpga.dtsi
+++ b/arch/arm/boot/dts/socfpga.dtsi
@@ -713,6 +713,9 @@
reg-shift = <2>;
reg-io-width = <4>;
clocks = <&l4_sp_clk>;
+ dmas = <&pdma 28>,
+ <&pdma 29>;
+ dma-names = "tx", "rx";
};

uart1: ***@ffc03000 {
@@ -722,6 +725,9 @@
reg-shift = <2>;
reg-io-width = <4>;
clocks = <&l4_sp_clk>;
+ dmas = <&pdma 30>,
+ <&pdma 31>;
+ dma-names = "tx", "rx";
};

rst: ***@ffd05000 {
--
2.1.4
Dinh Nguyen
2015-02-19 17:29:52 UTC
Permalink
Post by Steffen Trumtrar
socfpga.dtsi is missing the DMA channels for the uart nodes.
ttyS0 - failed to request DMA
Provide the correct DMA channels to fix this.
---
arch/arm/boot/dts/socfpga.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
index 252c3d1bda50..9d8760956752 100644
--- a/arch/arm/boot/dts/socfpga.dtsi
+++ b/arch/arm/boot/dts/socfpga.dtsi
@@ -713,6 +713,9 @@
reg-shift = <2>;
reg-io-width = <4>;
clocks = <&l4_sp_clk>;
+ dmas = <&pdma 28>,
+ <&pdma 29>;
+ dma-names = "tx", "rx";
};
@@ -722,6 +725,9 @@
reg-shift = <2>;
reg-io-width = <4>;
clocks = <&l4_sp_clk>;
+ dmas = <&pdma 30>,
+ <&pdma 31>;
+ dma-names = "tx", "rx";
};
--
2.1.4
Applied to fixes.

BR,
Dinh

Loading...